Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag depends on ForwardDiff backend object #229

Merged
merged 2 commits into from
Apr 29, 2024
Merged

Tag depends on ForwardDiff backend object #229

merged 2 commits into from
Apr 29, 2024

Conversation

gdalle
Copy link
Member

@gdalle gdalle commented Apr 29, 2024

Extensions

  • Choose tag type in ForwardDiff based on the one provided in the backend, unless it is Nothing in which case we use Tag{typeof(f),eltype(x)}
  • Replace indexing and broadcasting by map and map! for Dual creation and retrieval, so that it works beyond arrays

Note: ForwardDiff with a custom tag is not yet tested, might cause perturbation confusion in the second order

@codecov-commenter
Copy link

codecov-commenter commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 96.25%. Comparing base (cc73842) to head (ca92d31).
Report is 1 commits behind head on main.

Files Patch % Lines
...xt/DifferentiationInterfaceForwardDiffExt/utils.jl 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #229      +/-   ##
==========================================
+ Coverage   96.13%   96.25%   +0.11%     
==========================================
  Files          74       74              
  Lines        3911     3896      -15     
==========================================
- Hits         3760     3750      -10     
+ Misses        151      146       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gdalle gdalle merged commit e490e32 into main Apr 29, 2024
5 checks passed
@gdalle gdalle deleted the gd/typestab branch April 29, 2024 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants